launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

I am surprised that line 120 happens. Doesn't Lp have a hard-coded failover rule that selects the maintainer when a bug is marked private or private security. Well I know JC wrote real tests for that, so I am happy that this duplicate test is removed.

Maybe we want to delete lib/lp/bugs/stories/initial-bug-contacts/xx-initial-bug-contacts.txt
because Lp wont support this story in a few weeks. We will only have structural subscriptions.

I do not set a test for the crucial changes that start on line 207. I was expecting changes to the testcase on 619 to show that a structural subscriber with an APG does get email. We need  a test for dupes too since that was rewritten.

Maybe you want to land a branch that deletes the doctest and story changes...may even all of xx-initial-bug-contacts.txt since we no longer care about these example. Your this branch would then be about the rewrite
-- 
https://code.launchpad.net/~stevenk/launchpad/structsub-private-bugs/+merge/115277
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/structsub-private-bugs into lp:launchpad.