launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #10054
Re: [Merge] lp:~cjwatson/launchpad/garbo-archivepermission-duplicates into lp:launchpad
Review: Approve code*
Thanks Colin, this branch looks good.
It seems the tests contain some repeated code (to create ArchivePermissions), but I think that's ok since the job will be removed.
Tests pass, and you said on IRC that you checked the SQL fragment by hand on dogfood.
--
https://code.launchpad.net/~cjwatson/launchpad/garbo-archivepermission-duplicates/+merge/115554
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
Follow ups
References