launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Review: Approve

Thanks for the cleanup!

The test code could probably be more compact, but, like Francesco noted, this doesn't matter much since this will be ditched eventually.

I didn't know about window functions, I've always used regular aggregate functions to do that kind of stuff.  Thanks Colin!
-- 
https://code.launchpad.net/~cjwatson/launchpad/garbo-archivepermission-duplicates/+merge/115554
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.