launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/remove-security-uploadpolicy-restriction into lp:launchpad has been updated.

Description changed to:

== Summary ==

There is a restriction in archiveuploader preventing direct uploads to -security.  This dates from 2006, specifically from the days when -security was managed outside Launchpad and so it would have been bad to accept direct uploads.  Nowadays it so happens that the security team always stages uploads in a PPA and copies them over, and I don't think there's any particular drive to change that, but contrariwise there's no reason to keep this code fossil either.  It looks as though it was simply forgotten when the security upload policy was removed in r11450.

== Proposed fix ==

Just drop the check.

== Tests ==

bin/test -vvct archiveuploader

== Demo and Q/A ==

Upload something directly to precise-security on dogfood.  It should land in the unapproved queue rather than being rejected out of hand.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-security-uploadpolicy-restriction/+merge/115739
-- 
https://code.launchpad.net/~cjwatson/launchpad/remove-security-uploadpolicy-restriction/+merge/115739
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.