launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/maas/bug-1027154 into lp:maas has been updated.

Description changed to:

This branch adds the possibility to filter the nodes given by the (existing) API method 'list' with MAC addresses (only the nodes with the specific MAC addresses will be returned).

= Pre-imp =

Talked with Julian about this.

= Notes =

I choose to continue with the existing pattern of using the singular for criteria which are actually lists (i.e. 'mac_address' singular and 'id' singular).  The reason behind that is that the API is called this way: /api/1.0/nodes/?op=list&mac_address=<MAC1>&mac_address=<MAC2>.

For more details, see:
https://code.launchpad.net/~rvb/maas/bug-1027154/+merge/116241
-- 
https://code.launchpad.net/~rvb/maas/bug-1027154/+merge/116241
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/bug-1027154 into lp:maas.