launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

The proposal to merge lp:~rharding/launchpad/garden_client into lp:launchpad has been updated.

Description changed to:

= Summary =

In the process of getting some LoC points towards the bug fix in another
branch this performs some cleanup of the code in the client.js.

== Implementation Notes ==

Move all objects/methods not attached to the module (thus private) to the
top of the file.

Fix 2-space lines with 4-space indentation.

Change the ErrorHandler, FormErrorHandler, PatchPlugin to be created via
Y.Base.create().

Assign objects straight to module vs creating them as vars and then later
perform a:
module.SomeObject = SomeObject

Fixed a comment block to match.

Removing some double spaces lines to try to keep things consistant as there
are various 2-line/1-line spacing between objects and methods.

Make sure variables are declared (querystring) so that they don't leak to the
global window scope.

And some line length cleanup due to the increased tab depth from the prev
branch.

== Tests ==
                                                                                                                                                        xvfb-run ./bin/test -x -cvv --layer=YUITestLayer

== Lint ==

Linting changed files:
  lib/lp/app/javascript/client.js

== LoC Qualification ==

Negative LoC

For more details, see:
https://code.launchpad.net/~rharding/launchpad/garden_client/+merge/116330
-- 
https://code.launchpad.net/~rharding/launchpad/garden_client/+merge/116330
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/garden_client into lp:launchpad.