launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/ditch-pxe-config-files into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/ditch-pxe-config-files/+merge/116645

Now that we have a dynamic TFTP server built in, there's no point to the PXEConfig class writing PXE config files straight to the file system, or even to know about the TFTP filesystem tree and what MAC addresses look like etc.  It's there strictly to generate PXE configs now, not to determine where they go.

On the other hand, PXEConfig or its caller will have to learn about generating PXE configurations for different purposes: enlistment, commissioning, and installation.  Currently it really only does enlistment.  But chances are that we'll want a different way of specifying that than the boolean implied by “mac is None.”


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/ditch-pxe-config-files/+merge/116645
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/ditch-pxe-config-files into lp:maas.