launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #10297
Re: [Merge] lp:~jcsackett/launchpad/comment-list-delegates into lp:launchpad
Review: Approve
Hi Jon
Looks ok. It's hard to tell 100% that everything will be ok from just reading the code, I assume you've fully tested locally the bits that broke before as well as a quick re-test of the original stuff.
I'd remove this line from the yui test before landing:
console.log(comment_node);
--
https://code.launchpad.net/~jcsackett/launchpad/comment-list-delegates/+merge/116376
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
Follow ups
References