← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jcsackett/launchpad/comment-list-delegates into lp:launchpad

 

> Looks ok. It's hard to tell 100% that everything will be ok from just reading
> the code, I assume you've fully tested locally the bits that broke before as
> well as a quick re-test of the original stuff.

You assume correctly.
 
> I'd remove this line from the yui test before landing:
> console.log(comment_node);

Good catch; I'll kill that.
-- 
https://code.launchpad.net/~jcsackett/launchpad/comment-list-delegates/+merge/116376
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References