launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

Review: Approve

This looks fine.

I have no great suggestions for the info type constants. I suppose one could simply use proprietary's antonym, but NONPROPRIETARY_INFORMATION_TYPES, while slightly less ambiguous than FREE_* is almost as unwieldy as INFORMATION_TYPES_THAT_ARENT_PROPRIETARY.


-- 
https://code.launchpad.net/~wgrant/launchpad/branch-informationtype-refactor/+merge/116805
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.