launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

Review: Approve

> Surely auditorclient should be in its own package, not part of LP ?
> Other things than LP will want to use Auditor.

It is: see https://launchpad.net/auditorclient. The subclassing of it here seems sensible since there's no need for the enterpriseid stuff to be migrated into the auditorclient package.

I assume the import changes in enterpiseid.py are b/c of a circular import issue. May be worth it to add a comment indicating such.

Otherwise, this looks good to me. Thanks, Steve.
-- 
https://code.launchpad.net/~stevenk/launchpad/auditor-for-packageupload/+merge/116180
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.