launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/lp-dev-utils/ec2-errors into lp:lp-dev-utils.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~abentley/lp-dev-utils/ec2-errors/+merge/116891

This just fixes the ec2 error handling so that user errors don't generate tracebacks.
-- 
https://code.launchpad.net/~abentley/lp-dev-utils/ec2-errors/+merge/116891
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/lp-dev-utils/ec2-errors into lp:lp-dev-utils.

=== modified file 'ec2'
--- ec2	2012-02-24 20:10:13 +0000
+++ ec2	2012-07-26 15:22:23 +0000
@@ -14,7 +14,7 @@
 import sys
 
 import bzrlib
-from bzrlib.errors import BzrCommandError
+from bzrlib.errors import BzrError
 
 from ec2test import builtins
 from ec2test.controller import (
@@ -46,7 +46,9 @@
             args = ['help']
         try:
             controller.run(args)
-        except BzrCommandError, e:
+        except BzrError as e:
+            if e.internal_error:
+                raise
             sys.exit('ec2: ERROR: ' + str(e))