launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

Jon,  thanks for the reviwe!

On 26.07.2012 17:19, j.c.sackett wrote:
> Review: Approve
> 
> Abel--
> 
> Looks alright. Two possible issues I'll leave to you to resolve before landing.
> 
> #710 you define like_query as query.lower(), then redefine it as another derivative of query; was the second line meant to be replaced, or further modify like_query instead of query?
> 
> #720 Same thing
> 

ouch... that should have been

            like_query = query.lower()
            like_query = "'%%' || %s || '%%'" % quote_like(like_query)

in both cases. Fixed.


-- 
https://code.launchpad.net/~adeuring/launchpad/bug-1020443-2/+merge/116876
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.