launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/misaligned-details into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1028558 in Launchpad itself: "table columns misaligned on sharing details page"
  https://bugs.launchpad.net/launchpad/+bug/1028558

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/misaligned-details/+merge/117118

Summary
=======
There are a few small cosmetic problems in the sharing details view;
misalignment, and text not spanning the appropriate columns.

Preimp
======
Spoke with Ian Booth, Curtis Hovey.

Implementation
==============
The bug summary in the details table view has been collapsed into one table
cell spanning the same number of columns.

The nothing shared message in details has been updated to cover all columns in
the table.

The main sharing table had a similar problem, resolved by simply reusing the
setup code for when there is nothing shared on the event where the last sharee
is removed. 

Tests
=====
bin/test -vvct shar* --layer=YUI

QA
==
Make sure the cosmetic issues are resolved in the sharing views.

LoC
===
This is part of disclosure.

Lint
====

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/javascript/sharing/granteetable.js
  lib/lp/registry/javascript/sharing/sharingdetails.js
-- 
https://code.launchpad.net/~jcsackett/launchpad/misaligned-details/+merge/117118
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/misaligned-details into lp:launchpad.

=== modified file 'lib/lp/registry/javascript/sharing/granteetable.js'
--- lib/lp/registry/javascript/sharing/granteetable.js	2012-07-23 03:40:33 +0000
+++ lib/lp/registry/javascript/sharing/granteetable.js	2012-07-27 19:03:22 +0000
@@ -501,6 +501,7 @@
     delete_grantees: function(grantees, all_rows_deleted) {
         var deleted_row_selectors = [];
         var grantee_table = this.get('grantee_table');
+        var that = this;
         Y.Array.each(grantees, function(grantee) {
             var selector = 'tr[id=permission-' + grantee.name + ']';
             var table_row = grantee_table.one(selector);
@@ -515,11 +516,10 @@
         var delete_rows = function() {
             rows_to_delete.remove(true);
             if (all_rows_deleted === true) {
+                var empty_table_row = Y.Node.create(
+                    that.get('grantee_table_empty_row'));
                 grantee_table.one('tbody')
-                    .appendChild('<tr id="grantee-table-not-shared"></tr>')
-                    .appendChild('<td></td>')
-                    .setContent("This project's private information " +
-                                "is not shared with anyone.");
+                    .appendChild(empty_table_row);
             }
         };
         var anim_duration = this.get('anim_duration');

=== modified file 'lib/lp/registry/javascript/sharing/sharingdetails.js'
--- lib/lp/registry/javascript/sharing/sharingdetails.js	2012-07-20 03:15:04 +0000
+++ lib/lp/registry/javascript/sharing/sharingdetails.js	2012-07-27 19:03:22 +0000
@@ -235,7 +235,7 @@
             if (all_rows_deleted === true) {
                 details_table_body
                     .appendChild('<tr></tr>')
-                    .appendChild('<td colspan="4"></td>')
+                    .appendChild('<td colspan="5"></td>')
                     .setContent("There are no shared bugs or branches.");
             }
         };
@@ -279,12 +279,12 @@
     _bug_details_row_template: function() {
         return [
         '<tr id="shared-bug-{{ bug_id }}">',
-        '    <td class="icon right">',
-        '        <span class="sortkey">{{bug_id}}</span>',
-        '        <span class="sprite bug-{{bug_importance}}"></span>',
-        '    </td>',
-        '    <td class="amount">{{bug_id}}</td>',
-        '    <td>',
+        '    <td colspan="3">',
+        '        <span class="icon left">',
+        '            <span class="sortkey">{{bug_id}}</span>',
+        '            <span class="sprite bug-{{bug_importance}}"></span>',
+        '        </span>',
+        '        <span class="amount">{{bug_id}}</span>',
         '        <a href="{{web_link}}">{{bug_summary}}</a>',
         '    </td>',
         '    <td class="action-icons nowrap">',