launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

Review: Approve code

I don't want to hold up this branch any further. I have some concerns that I would like addressed in a subsequent branch.

1. Search should use the search icon and be to the right of the text field. the spinner replaces it when active. I think this is the same position and behaviour as the person picker. I don't think we need the Search or Search Again buttons in the bottom.

2. I like your close button, but I want one kind of art used for all overlay close buttons. I think I prefer yours...I did not know that the choice picker had a [x] until I fixed the keyboard behavour -- The icon looks bad when it is selected, and it was always selected until I fixed it.
-- 
https://code.launchpad.net/~wallyworld/launchpad/private-dupe-bug-warning3/+merge/116997
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.