launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/launchpad/longer-mq-timeout into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1031018 in Launchpad itself: "TestRunMissingJobs.test_find_missing_ready fails intermittantly"
  https://bugs.launchpad.net/launchpad/+bug/1031018

For more details, see:
https://code.launchpad.net/~abentley/launchpad/longer-mq-timeout/+merge/117324

= Summary =
Fix bug #1031018: TestRunMissingJobs.test_find_missing_ready fails intermittantly

== Proposed fix ==
Increase the maximum waiting time to 1 minute.

== Pre-implementation notes ==
None

== LOC Rationale ==
LOC neutral

== Implementation details ==
find_missing_ready waits for the message queue to be populated, and this has reduced, but not eliminated test failures.  I hope that increasing the time limit will eliminate them.

== Tests ==
bin/test -t TestRunMissingJobs.test_find_missing_ready

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/job/tests/test_celeryjob.py
-- 
https://code.launchpad.net/~abentley/launchpad/longer-mq-timeout/+merge/117324
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/longer-mq-timeout into lp:launchpad.

=== modified file 'lib/lp/services/job/tests/test_celeryjob.py'
--- lib/lp/services/job/tests/test_celeryjob.py	2012-07-26 19:26:17 +0000
+++ lib/lp/services/job/tests/test_celeryjob.py	2012-07-30 19:12:21 +0000
@@ -45,7 +45,7 @@
         delivery.
         """
         from lazr.jobrunner.celerytask import list_queued
-        for x in range(100):
+        for x in range(600):
             actual_len = len(list_queued(app, queues))
             if actual_len == expected_len:
                 return