launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/no-more-id-for-bsfs into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-more-id-for-bsfs/+merge/117374

Prepare to drop the id columns of BugSubscriptionFilter{Status,Importance} for being useless.
-- 
https://code.launchpad.net/~stevenk/launchpad/no-more-id-for-bsfs/+merge/117374
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/no-more-id-for-bsfs into lp:launchpad.

=== modified file 'lib/lp/bugs/model/bugsubscriptionfilterimportance.py'
--- lib/lp/bugs/model/bugsubscriptionfilterimportance.py	2011-12-30 06:14:56 +0000
+++ lib/lp/bugs/model/bugsubscriptionfilterimportance.py	2012-07-31 05:23:20 +0000
@@ -20,8 +20,7 @@
     """Importances to filter."""
 
     __storm_table__ = "BugSubscriptionFilterImportance"
-
-    id = Int(primary=True)
+    __storm_primary__ ('filter', 'importance')
 
     filter_id = Int("filter", allow_none=False)
     filter = Reference(filter_id, "BugSubscriptionFilter.id")

=== modified file 'lib/lp/bugs/model/bugsubscriptionfilterstatus.py'
--- lib/lp/bugs/model/bugsubscriptionfilterstatus.py	2011-12-30 06:14:56 +0000
+++ lib/lp/bugs/model/bugsubscriptionfilterstatus.py	2012-07-31 05:23:20 +0000
@@ -20,8 +20,7 @@
     """Statuses to filter."""
 
     __storm_table__ = "BugSubscriptionFilterStatus"
-
-    id = Int(primary=True)
+    __storm_primary__ = ('filter', 'status')
 
     filter_id = Int("filter", allow_none=False)
     filter = Reference(filter_id, "BugSubscriptionFilter.id")