launchpad-reviewers team mailing list archive

[Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>]

The proposal to merge lp:~sinzui/launchpad/remove-automatic-renewal into lp:launchpad has been updated.

Description changed to:

RULES

    Pre-implementation: no one
    * Remove all the code that is aware of
      TeamMembershipRenewalPolicy.AUTOMATIC
    * Prepare a SQL script that can be run *before* the branch in deployed
      to update the ~130 teams that use AUTOMATIC to clearly state that
      memberships do not expire.

    Extra credit
    * Indent the renewal period field so that it is beneath the ONDEAMND
      TeamMembershipRenewalPolicy item in the form.
    * Revise the text so that it is clear that the field is only needed
      by ONDEMAND.

QA

    http://people.canonical.com/~curtis/self-renewal.png
    shows the text and position changes.

    * Visit https://qastaging.launchpad.net/~launchpad-dev/+edit
    * Verify the two choices for renewal are invite to *apply*, or *Renew*.
    * Verify the renewal period is beneath the Renew radio option.

LINT

    cronscripts/flag-expired-memberships.py
    lib/lp/registry/configure.zcml
    lib/lp/registry/doc/teammembership-email-notification.txt
    lib/lp/registry/doc/teammembership.txt
    lib/lp/registry/interfaces/person.py
    lib/lp/registry/interfaces/teammembership.py
    lib/lp/registry/model/teammembership.py
    lib/lp/registry/tests/test_team.py
    lib/lp/registry/tests/test_teammembership.py

    There is lint in ./lib/lp/registry/interfaces/teammembership.py that I
    can cleanup before I land.

TEST

    ./bin/test -vvc -t doc/teammembership lp.registry.tests
    ./bin/test -vvc lp.registry.tests.test_team
    ./bin/test -vvc lp.registry.tests.test_teammembership

IMPLEMENTATION

SQL that *must* be run just before delopyments
    http://pastebin.ubuntu.com/1123577/

Removed TeamMembershipRenewalPolicy.AUTOMATIC and all code that was aware
of it.
    cronscripts/flag-expired-memberships.py
    lib/lp/registry/configure.zcml
    lib/lp/registry/doc/teammembership-email-notification.txt
    lib/lp/registry/doc/teammembership.txt
    lib/lp/registry/interfaces/person.py
    lib/lp/registry/interfaces/teammembership.py
    lib/lp/registry/model/teammembership.py
    lib/lp/registry/tests/test_team.py
    lib/lp/registry/tests/test_teammembership.py

Revised the field descriptions and indented the renewal period field.
    lib/lp/registry/browser/team.py
    lib/lp/registry/interfaces/person.py

For more details, see:
https://code.launchpad.net/~sinzui/launchpad/remove-automatic-renewal/+merge/117486
-- 
https://code.launchpad.net/~sinzui/launchpad/remove-automatic-renewal/+merge/117486
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.