← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~stevenk/launchpad/bugsubscriptionfilter-itype into lp:launchpad

 

Review: Approve code

26	+ value_type=Choice(
27	+ title=_('Information Type'), vocabulary=InformationType)))

"Information type" isn't a proper noun, so it gets sentence case here, like the other multi-word attributes above.

I'd also possibly like to see some investigation into factoring some commonalities out of _set_{statuses,importances,tags,information_types}, but it may get ugly fast.
-- 
https://code.launchpad.net/~stevenk/launchpad/bugsubscriptionfilter-itype/+merge/117825
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References