← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/bugpicker-search-button-1031544 into lp:launchpad

 

Thanks for getting through the many lines in this mp.

> 
> I don't think "please" is required on line 68, the application will not be
> polite it you make a mistake.
> 

This is copied directly from the existing base lazr picker code. I made it into an attribute so it could be overridden. So I'm not creating new text in this mp. I'll update the message and also the existing lazr picker yui tests if you do want to go ahead with the wording change.
-- 
https://code.launchpad.net/~wallyworld/launchpad/bugpicker-search-button-1031544/+merge/117839
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References