← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~abentley/launchpad/better-find-missing-ready-error into lp:launchpad

To: Aaron Bentley <aaron@xxxxxxxxxxxxx>
From: Abel Deuring <abel.deuring@xxxxxxxxxxxxx>
Date: Thu, 02 Aug 2012 15:42:19 -0000
In-reply-to: <20120802153024.14577.92118.launchpad@ackee.canonical.com>
Reply-to: mp+117926@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

looks good, just a minor nitpick: I think that

+ from lp.services.job.celeryjob import FindMissingReady

could be moved to the start f the method definition.
-- 
https://code.launchpad.net/~abentley/launchpad/better-find-missing-ready-error/+merge/117926
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~abentley/launchpad/better-find-missing-ready-error into lp:launchpad
From: Aaron Bentley, 2012-08-02