← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~abentley/launchpad/blueprint-info-type-idx into lp:launchpad

 

Aaron Bentley has proposed merging lp:~abentley/launchpad/blueprint-info-type-idx into lp:launchpad with lp:~abentley/launchpad/blueprint-info-type-db as a prerequisite.

Requested reviews:
  Robert Collins (lifeless): db
  Stuart Bishop (stub): db

For more details, see:
https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-idx/+merge/117980

= Summary =
Add an index to Specification.information_type
(Added in https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-db/+merge/117979)

== Pre-implementation notes ==
Discussed with lifeless and wgrant

== LOC Rationale ==
Part of Private Projects

== Implementation details ==
Did not use CREATE INDEX CONCURRENTLY, because "make schema" complained about transactions.
Hot patch targeted at devel per lifeless' directions.

== Tests ==
None

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/patch-2209-28-1.sql
  database/schema/comments.sql
  database/schema/patch-2209-28-2.sql
-- 
https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-idx/+merge/117980
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
=== added file 'database/schema/patch-2209-28-2.sql'
--- database/schema/patch-2209-28-2.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-28-2.sql	2012-08-02 19:50:26 +0000
@@ -0,0 +1,8 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE INDEX specification__information_type__idx ON Specification(information_type);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 28, 2);


Follow ups