launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #10553
[Merge] lp:~abentley/launchpad/blueprint-info-type-remove-garbo into lp:launchpad
The proposal to merge lp:~abentley/launchpad/blueprint-info-type-remove-garbo into lp:launchpad has been updated.
Description changed to:
= Summary =
Remove garbo job
Previous: https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-code/+merge/117981
Next: https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-not-null/+merge/117986
== Proposed fix ==
The garbo job's tests assume that Specification.information_type is nullable. Before we can set it to NOT NULL, we must remove the tests, and therefore the job.
== Pre-implementation notes ==
Advised by lifeless and wgrant
== LOC Rationale ==
Part of Private Projects
== Implementation details ==
None
== Tests ==
None
== Demo and Q/A ==
None
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
database/schema/patch-2209-28-1.sql
database/schema/comments.sql
database/schema/security.cfg
lib/lp/blueprints/model/specification.py
database/schema/patch-2209-28-2.sql
lib/lp/blueprints/interfaces/specification.py
For more details, see:
https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-remove-garbo/+merge/117983
--
https://code.launchpad.net/~abentley/launchpad/blueprint-info-type-remove-garbo/+merge/117983
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References