launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/publishinghistory-show-copier into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1032857 in Launchpad itself: "DistributionSourcePackage:+publishinghistory should show the audit trail of copies"
  https://bugs.launchpad.net/launchpad/+bug/1032857

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/publishinghistory-show-copier/+merge/118223

== Summary ==

There's no way to see who copied a package in the +publishinghistory UI; you have to wheel out the API and look at SPPH.creator.  This is more cumbersome than it should be.

== Proposed fix ==

Add "by [creator]" to the template if we know who that is.

== LOC Rationale ==

+5.  I have 3911 lines of credit.

== Tests ==

bin/test -vvct soyuz/stories/ppa/xx-copy-packages.txt

== Demo and Q/A ==

Find a package that's been copied using a PCJ - the auto-syncer is a good source of these on old DB snapshots such as qastaging, so try https://qastaging.launchpad.net/ubuntu/+source/man-db/+publishinghistory - and look for the new text.
-- 
https://code.launchpad.net/~cjwatson/launchpad/publishinghistory-show-copier/+merge/118223
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/publishinghistory-show-copier into lp:launchpad.

=== modified file 'lib/lp/soyuz/stories/ppa/xx-copy-packages.txt'
--- lib/lp/soyuz/stories/ppa/xx-copy-packages.txt	2012-01-15 11:06:57 +0000
+++ lib/lp/soyuz/stories/ppa/xx-copy-packages.txt	2012-08-04 00:33:21 +0000
@@ -272,7 +272,8 @@
     >>> jblack_extra_browser.open(expander_url)
     >>> print extract_text(jblack_extra_browser.contents)
     Publishing details
-      Copied from ubuntu hoary in Primary Archive for Ubuntu Linux
+      Copied from ubuntu hoary in Primary Archive for Ubuntu Linux by
+      <a href="/~jblack"...>James Blackwell</a>
     Changelog
       pmount (0.1-1) hoary; urgency=low
       * Fix description (Malone #1)

=== modified file 'lib/lp/soyuz/templates/packagepublishing-details.pt'
--- lib/lp/soyuz/templates/packagepublishing-details.pt	2012-02-10 10:14:20 +0000
+++ lib/lp/soyuz/templates/packagepublishing-details.pt	2012-08-04 00:33:21 +0000
@@ -55,6 +55,10 @@
                     message string:${archive/displayname}"
             replace="message" />
         </tal:define>
+        <tal:message
+          condition="context/creator"
+          define="message string: by ${context/creator/fmt:link}"
+          replace="message" />
       </tal:source_original_location>
       <tal:binary_build_location condition="view/is_binary">
         <tal:message