launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/maas/more-kernel-options-ephemeral into lp:maas has been updated.

Description changed to:

This branch adds the name of the ephemeral to the iscsi_target_name parameters in the kernel command line.

The maas-import-ephemerals script imports ephemeral images and also creates an 'info' file which contains the information we need to use in the iscsi_target_name parameter.  The ephemeral info are in directory named after the release data (e.g.  /var/lib/maas/ephemeral/precise/ephemeral/i386/20120424/info).

= Pre-imp =

This was mostly discussed with Scott.

We thought of two ways to do this:
a) modify the maas-import-ephemerals so that it would maintain a symbolic link to the last ephemeral import.
b) list the directories for a specific release/architecture, sort them, and take the first one.

I choose solution b) as it doesn't require to change the script, it still lets an admin trick the system (by manually creating a new directory) if one wants to use an old ephemeral image.

= Notes =

I've added the utility parse_config() to parse the ephemeral info file (and I've used it in omshell).

I think we should improve the error handling in get_first_directory() and get_ephemeral_name() to raise a proper error when the import hasn't been run.  But this will happen in a follow-up branch.

For more details, see:
https://code.launchpad.net/~rvb/maas/more-kernel-options-ephemeral/+merge/118397
-- 
https://code.launchpad.net/~rvb/maas/more-kernel-options-ephemeral/+merge/118397
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/more-kernel-options-ephemeral into lp:maas.