← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/pocket-queue-admin into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Steve Kowalik <stevenk@xxxxxxxxxx>
Date: Wed, 08 Aug 2012 01:41:18 -0000
In-reply-to: <20120801120620.20028.18708.launchpad@ackee.canonical.com>
Reply-to: mp+117630@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

Broadly, this looks excellent. Have you considered using login_person() from lp.testing so that you don't have to set e-mail addresses when you create roles for tests?
-- 
https://code.launchpad.net/~cjwatson/launchpad/pocket-queue-admin/+merge/117630
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/pocket-queue-admin into lp:launchpad
From: Colin Watson, 2012-08-01