launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/no-ibug-private-default into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/no-ibug-private-default/+merge/118661

A followup to the isolated fix for bug #1034089, this branch drops the default values of False from IBug['private'] and IBug['security_related']. This lets them default to None, so createBug knows to use the target-specific default. IMaloneApplication['createBug'] no longer needs to override them.
-- 
https://code.launchpad.net/~wgrant/launchpad/no-ibug-private-default/+merge/118661
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/no-ibug-private-default into lp:launchpad.

=== modified file 'lib/lp/bugs/interfaces/bug.py'
--- lib/lp/bugs/interfaces/bug.py	2012-08-06 03:47:42 +0000
+++ lib/lp/bugs/interfaces/bug.py	2012-08-08 02:23:40 +0000
@@ -208,7 +208,6 @@
         Bool(title=_("This bug report should be private"), required=False,
              description=_("Private bug reports are visible only to "
                            "their subscribers."),
-             default=False,
              readonly=True))
     information_type = exported(
         Choice(
@@ -343,7 +342,7 @@
             readonly=True)))
     security_related = exported(
         Bool(title=_("This bug is a security vulnerability."),
-             required=False, default=False, readonly=True))
+             required=False, readonly=True))
     has_patches = Attribute("Does this bug have any patches?")
     latest_patch_uploaded = exported(
         Datetime(

=== modified file 'lib/lp/bugs/interfaces/malone.py'
--- lib/lp/bugs/interfaces/malone.py	2012-08-07 22:29:30 +0000
+++ lib/lp/bugs/interfaces/malone.py	2012-08-08 02:23:40 +0000
@@ -74,11 +74,9 @@
         target=Reference(
             schema=IBugTarget, required=True,
             title=u"The project, distribution or source package that has "
-                   "this bug."),
-        security_related=copy_field(IBug['security_related'], default=None),
-        private=copy_field(IBug['private'], default=None))
+                   "this bug."))
     @export_factory_operation(
-        IBug, ['title', 'description', 'tags'])
+        IBug, ['title', 'description', 'tags', 'security_related', 'private'])
     def createBug(owner, title, description, target, security_related=None,
                   private=None, tags=None):
         """Create a bug (with an appropriate bugtask) and return it.