← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/launchpad/publishinghistory-show-copier into lp:launchpad

 

I agree the high count is unpleasant, but I checked that it was the same
before this branch (or else I'd be worried), so it probably just
reflects +publishinghistory being dreadful already.  Remember that those
10 queries are for two SPPHs.

Both SPPHs involve queries for Component and Section, and as you say
DistroSeries.  Then there's Archive and Distribution in the case of the
copied SPPH, and an extra Person query for the archive owner there as
well.  My count seems to be off by one somewhere but that's most of it.

I had a brief go at improving this, but I think it needs rather more
care than I have time for right now and should get independent review.
Given that bug 739066 exists, and this branch isn't a regression in
terms of query count as far as I can see, I think it would be best to
address the high per-SPPH count separately.

-- 
https://code.launchpad.net/~cjwatson/launchpad/publishinghistory-show-copier/+merge/118223
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References