← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wallyworld/launchpad/buglisting-text-alignment-1029526 into lp:launchpad

 

Ian Booth has proposed merging lp:~wallyworld/launchpad/buglisting-text-alignment-1029526 into lp:launchpad.

Requested reviews:
  Ian Booth (wallyworld)
Related bugs:
  Bug #1029526 in Launchpad itself: "Information type is misaligned in bug listings"
  https://bugs.launchpad.net/launchpad/+bug/1029526

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/buglisting-text-alignment-1029526/+merge/119089

A simple css tweak to improve the bug listing page, specifically the text alignment for information type.
-- 
https://code.launchpad.net/~wallyworld/launchpad/buglisting-text-alignment-1029526/+merge/119089
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
=== modified file 'lib/canonical/launchpad/icing/css/components/bug_listing.css'
--- lib/canonical/launchpad/icing/css/components/bug_listing.css	2012-07-16 01:24:26 +0000
+++ lib/canonical/launchpad/icing/css/components/bug_listing.css	2012-08-10 08:05:21 +0000
@@ -28,12 +28,13 @@
 div#client-listing .importance,
 div#client-listing .information_type {
     float: left;
-    height: 1.5em;
+    height: 1.4em;
     font-size: 0.8em;
     border-radius: 2px;
     text-transform: uppercase;
     line-height: 12px;
     text-align: center;
+    padding-top: 0.1em;
     margin: 5px 10px 0 0;
     }
 
@@ -46,8 +47,8 @@
     }
 
 div#client-listing .information_type {
-    height: 1em;
-    width: 160px;
+    width: 165px;
+    background-color: #dcdcdc;
     }
 
 div#client-listing .field {

=== modified file 'lib/canonical/launchpad/icing/css/components/sharing.css'
--- lib/canonical/launchpad/icing/css/components/sharing.css	2012-07-21 03:04:06 +0000
+++ lib/canonical/launchpad/icing/css/components/sharing.css	2012-08-10 08:05:21 +0000
@@ -13,8 +13,7 @@
     padding-right: 10px;
     }
 
-table.sharing ul.horizontal li div,
-.information_type {
+table.sharing ul.horizontal li div {
     display: inline;
     border-radius: 5px;
     background-color: #dcdcdc;


Follow ups