launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Benji York has proposed merging lp:~benji/python-pgbouncer/longer-timeouts into lp:python-pgbouncer.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~benji/python-pgbouncer/longer-timeouts/+merge/119187

We are using python-pgbouncer on a heavily loaded machine and having
problems with timeouts.  Given that 5 seconds isn't very long we hope
that a timeout of 60 will improve things.

The tests still pass (after I got the buildout to work, see my upcoming
merge proposal).

I couldn't see a reason why the original five second default was a
float, so I changed it to an int.

-- 
https://code.launchpad.net/~benji/python-pgbouncer/longer-timeouts/+merge/119187
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/python-pgbouncer/longer-timeouts into lp:python-pgbouncer.

=== modified file 'pgbouncer/fixture.py'
--- pgbouncer/fixture.py	2011-10-28 11:45:32 +0000
+++ pgbouncer/fixture.py	2012-08-10 20:37:24 +0000
@@ -28,7 +28,7 @@
 from testtools.content import content_from_file
 
 
-def countdown(duration=5.0, sleep=0.1):
+def countdown(duration=60, sleep=0.1):
     """Provide a countdown iterator that sleeps between iterations.
 
     Yields the current iteration count, starting from 1.