← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~rvb/maas/share-mem into lp:maas

To: mp+119371@xxxxxxxxxxxxxxxxxx
From: Julian Edwards <julian.edwards@xxxxxxxxxxxxx>
Date: Tue, 14 Aug 2012 02:33:18 -0000
In-reply-to: <20120813155848.29276.65036.launchpad@ackee.canonical.com>
Reply-to: mp+119371@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I've not done a full review yet but just something I noticed - does this handle the other shared secrets other than API creds?  It appears not but then I only skimmed it as I am running out for a lunch appointment.
-- 
https://code.launchpad.net/~rvb/maas/share-mem/+merge/119371
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/share-mem into lp:maas.

References

[Merge] lp:~rvb/maas/share-mem into lp:maas
From: Raphaël Badin, 2012-08-13