launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Careful.  In provisioningserver.auth.get_recorded_nodegroup_name, you read recorded_nodegroup_name twice and expect consistency between the two values.  This is exactly the kind of hazard I brought up in the pre-imp call.  It seems to me that that consistency is not guaranteed here, but if it is, at least document why!
-- 
https://code.launchpad.net/~rvb/maas/share-mem/+merge/119371
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/share-mem into lp:maas.