← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~stevenk/launchpad/drop-enhanced_choice_popup into lp:launchpad

To: Steve Kowalik <stevenk@xxxxxxxxxx>
From: Ian Booth <ian.booth@xxxxxxxxxxxxx>
Date: Tue, 14 Aug 2012 03:26:19 -0000
In-reply-to: <20120814022419.21354.296.launchpad@ackee.canonical.com>
Reply-to: mp+119461@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good to go. I'd rename the test case now that new tests are added or even keep the existing test case and add the new tests to a new one in the same module.
-- 
https://code.launchpad.net/~stevenk/launchpad/drop-enhanced_choice_popup/+merge/119461
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~stevenk/launchpad/drop-enhanced_choice_popup into lp:launchpad
From: Steve Kowalik, 2012-08-14