← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/edit-sharing-policies-1036437 into lp:launchpad

 

Editing is controlled by the sharing_write_enabled flag in the request 
cache.  The presence of this flag for maintainers is tested elsewhere. 
So I'll add a yui test to ensure editing bug/branch sharing policies is 
not enabled unless the flag is true.


On Wed 15 Aug 2012 02:45:24 EST, Curtis Hovey wrote:
> Review: Needs Information code
>
> The code/tests do not demonstrate that only maintainers see the edit widgets. Drivers cannot change sharing policies.

-- 
https://code.launchpad.net/~wallyworld/launchpad/edit-sharing-policies-1036437/+merge/119466
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References