← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad

 

The proposal to merge lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad has been updated.

Description changed to:

Currently, if you request a daily build of a recipe that contains an obsolete series (such as Maverick), you get an OOPS since the code raises a BuildNotAllowedForDistro exception, which is not caught.

I have changed ISourcePackageRecipe.performDailyBuild() to filter out distroseries which can't be built, and have added a helper method which the view calls to add a warning to the notification.

Also driveby a little cleanup.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654
-- 
https://code.launchpad.net/~stevenk/launchpad/no-oops-request-daily-build/+merge/119654
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/no-oops-request-daily-build into lp:launchpad.


References