launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

Thanks for this cleanup. I wonder if you could go even further by porting some bug_supervisor setters to use makeProduct(bug_supervisor=) instead, as a few seem to be ignorant of its existence.

610	Let's make Foo Bar a bug supervisor for upstream firefox:
611	
612	- >>> mozilla_firefox.setBugSupervisor(foobar, foobar)
613	+ >>> mozilla_firefox.bug_supervisor = foobar

Is this bit necessary any more? The rest of the test looks like it was just testing notification.

1426	def testPersonCanSetSelfAsSupervisor(self):
1427	# A person can set themselves as bug supervisor for a product.
1428	# This is a regression test for bug 438985.

This test can probably die now.
-- 
https://code.launchpad.net/~stevenk/launchpad/no-structsub-for-bug-supervisor/+merge/119831
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.