launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/update-sharing-policy-spinner into lp:launchpad.

Requested reviews:
  Ian Booth (wallyworld)
Related bugs:
  Bug #1037839 in Launchpad itself: "Progress spinner not working on sharing policy popup on +sharing page"
  https://bugs.launchpad.net/launchpad/+bug/1037839

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/update-sharing-policy-spinner/+merge/120033

The edit action icons used for the popup sharing policy widget use sprites to set the icon image. The choiceedit widget _uiSetWaiting() and _uiClearWaiting() methods assume the icon img src attribute is to be used to show the spinner and this doesn't work with sprites. So I made a quick tweak to manipulate the icon class directly.
-- 
https://code.launchpad.net/~wallyworld/launchpad/update-sharing-policy-spinner/+merge/120033
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/registry/javascript/sharing/pillarsharingview.js'
--- lib/lp/registry/javascript/sharing/pillarsharingview.js	2012-08-16 00:19:42 +0000
+++ lib/lp/registry/javascript/sharing/pillarsharingview.js	2012-08-17 00:14:20 +0000
@@ -334,13 +334,16 @@
         };
         this._update_policy_portlet(artifact_type, value);
         var pillar_uri = LP.cache.context.self_link;
+        var actionicon = widget.get("actionicon");
         var y_config =  {
             on: {
                 start: function() {
-                    widget._uiSetWaiting();
+                    actionicon.removeClass('edit');
+                    actionicon.addClass('spinner');
                 },
                 end: function() {
-                    widget._uiClearWaiting();
+                    actionicon.addClass('edit');
+                    actionicon.removeClass('spinner');
                 },
                 success: function() {
                     self.save_sharing_policy_success(