launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Review: Approve

Looks great. A few quibbles:

Small typos:

35	+ """IBranch attributes that can be edited by a more than one community."""
56	+ """IBranch methods that can be edited by a more than one community."""

I think this was unintentional:

195	+ """Tests for `Branch.commitsFornDays`."""

With the BranchModerateTestCase tests, we check access is granted for product owner and commercial admin. Could you please add in checks for branch owner to be complete.
-- 
https://code.launchpad.net/~sinzui/launchpad/project-branch-permissions/+merge/120219
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.