launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Approve

This seems reasonable.

If you are worried about performance going from bad to timeout, a feature flag may be appropriate to be able to turn off the new behavior easily.

On the database side, we can try helping with targetted indexes. We should probably add trigram indexes to BinaryPackageName.name, SourcePackageName.name and PackageCopyJob.package_name to allow us to avoid a full table scan to do the substring matches, but I don't think this will make too much of a difference in this case.
-- 
https://code.launchpad.net/~cjwatson/launchpad/queue-filter-source/+merge/119225
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.