launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Review: Approve code

This is a very nice improvement, thanks.

One thought: line 95 of the diff is

    overrides = defaultdict(lambda: defaultdict(set))

I don't know if I prefer one or the other and, honestly, LP has a few
simple lambdas where they make sense, so don't feel compelled to change
the code, but I thought I would provide an alternative in case it
strikes your fancy:

    overrides = defaultdict(defaultdict(set).copy)

Since this is an empty dictionary, the copy is cheap and safe.

There is similar code on line 235 of the diff.

-- 
https://code.launchpad.net/~cjwatson/launchpad/unnecessary-publisher-work/+merge/120356
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.