← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~sinzui/launchpad/commercial-admin-sharing into lp:launchpad

To: Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>
From: Ian Booth <ian.booth@xxxxxxxxxxxxx>
Date: Mon, 20 Aug 2012 21:58:21 -0000
In-reply-to: <20120820202531.15042.362.launchpad@ackee.canonical.com>
Reply-to: mp+120464@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks nice. Should there be a couple of negative tests to ensure we don't leak access to bugs and blueprints? I think we do need these.
-- 
https://code.launchpad.net/~sinzui/launchpad/commercial-admin-sharing/+merge/120464
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~sinzui/launchpad/commercial-admin-sharing into lp:launchpad
From: Curtis Hovey, 2012-08-20