launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/edit-import-link-1039294 into lp:launchpad.

Requested reviews:
  Ian Booth (wallyworld)
Related bugs:
  Bug #1039294 in Launchpad itself: ""Edit import source or review import" link opens a bug picker"
  https://bugs.launchpad.net/launchpad/+bug/1039294

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/edit-import-link-1039294/+merge/120490

The "Edit import source or review import" link on the branch page had an HTML id of "linkbug". I don't know why. It didn't matter before, but now that there's some Javascript to look for links with id "linkbug" in order to wire up the bug picker, it does matter now. So I just renamed the link in the TAL.
-- 
https://code.launchpad.net/~wallyworld/launchpad/edit-import-link-1039294/+merge/120490
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/code/templates/branch-import-details.pt'
--- lib/lp/code/templates/branch-import-details.pt	2012-07-07 14:00:30 +0000
+++ lib/lp/code/templates/branch-import-details.pt	2012-08-21 01:12:28 +0000
@@ -164,7 +164,7 @@
             tal:define="link context_menu/edit_import"
             tal:condition="link/enabled"
             >
-            <a id="linkbug"
+            <a id="edit-import"
                class="sprite add"
                tal:attributes="href link/url"
                tal:content="link/text" />