launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~sinzui/launchpad/entitle-branch-sharing into lp:launchpad

To: Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Wed, 22 Aug 2012 01:53:38 -0000
In-reply-to: <20120817193317.13321.69074.launchpad@ackee.canonical.com>
Reply-to: mp+120225@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

This can't land before <https://code.launchpad.net/~sinzui/launchpad/commercial-admin-sharing/+merge/120464>, as in this branch there's no access check at all on setBugSharingPolicy or setBranchSharingPolicy. If your new permission from the other branch is sufficient, perhaps remove the unused user argument from setFooSharingPolicy.
-- 
https://code.launchpad.net/~sinzui/launchpad/entitle-branch-sharing/+merge/120225
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~sinzui/launchpad/entitle-branch-sharing into lp:launchpad
From: Curtis Hovey, 2012-08-17