launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

I have changed the implementation. The information type change is submitted, but the change action checks to see if the bug would become invisible. A hidden widget (validate_change) is used. This allows the normal html form to be rendered without any changes, but the xhr call can set this to true or false as required. So when a new value is submitted, validate_change = true. The check is done. It returns status 400 if the bug becomes invisible. A popup allows the user to confirm the change. Then the submit is done again, with validate_change = false. 

A bug is considered visible so long as any one (or more) of its affected_pillars have policies that allow the bug to be seen. Did we want this, or should the bug be invisible if *any* of the pillars are missing the required policy to allow the bug to be seen?
-- 
https://code.launchpad.net/~wallyworld/launchpad/bug-security-warning-1033893/+merge/120916
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.