launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

> I see that
> lib/lp/app/javascript/choiceedit/choiceedit.js and
> lib/lp/bugs/javascript/bug_tags_entry.js both do not change to "lp.ui-base".
> Is this because they imported lazr.base, but they did not need to?

Correct; I think at some point they were using lazr.base, but a refactor removed the use. Alternatively, it was just an overzealous "require" statement.
-- 
https://code.launchpad.net/~jcsackett/launchpad/kill-lazr-1/+merge/121079
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.