launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/lpsetup/xbit into lp:lpsetup.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~bac/lpsetup/xbit/+merge/121259

When lpsetup is installed, the script lpsetup/bin/launchpad-database-setup loses its execution bit when put into the egg which results in a permission error when it is invoked.

It looks like there is a bug in the installer (acknowledged but not fixed).  The easiest work-around is to just call it via invoking /bin/sh on the script instead.
-- 
https://code.launchpad.net/~bac/lpsetup/xbit/+merge/121259
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/lpsetup/xbit into lp:lpsetup.

=== modified file 'lpsetup/subcommands/init_target.py'
--- lpsetup/subcommands/init_target.py	2012-08-22 16:48:50 +0000
+++ lpsetup/subcommands/init_target.py	2012-08-24 18:55:23 +0000
@@ -269,7 +269,7 @@
         script_name = 'launchpad-database-setup'
         here = os.path.dirname(__file__)
         script_path = os.path.join(here, '..', 'bin', script_name)
-        call(script_path, user)
+        call('/bin/sh', script_path, user)
 
 setup_database.description = """Setup database for Launchpad use."""