launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/bug-security-warning2-1033893 into lp:launchpad.

Requested reviews:
  Ian Booth (wallyworld)
Related bugs:
  Bug #1033893 in Launchpad itself: "should give warnings and ask for confirmation to set a bug as a security issue"
  https://bugs.launchpad.net/launchpad/+bug/1033893

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/bug-security-warning2-1033893/+merge/121350

Quick fix to only perform visibility check for private information types when the information type of a bug is changed. Done to fix rev 15863.
-- 
https://code.launchpad.net/~wallyworld/launchpad/bug-security-warning2-1033893/+merge/121350
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/bugs/browser/bug.py'
--- lib/lp/bugs/browser/bug.py	2012-08-24 12:49:00 +0000
+++ lib/lp/bugs/browser/bug.py	2012-08-26 22:57:21 +0000
@@ -2,7 +2,6 @@
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """IBug related view classes."""
-from lp.app.interfaces.services import IService
 
 __metaclass__ = type
 
@@ -72,6 +71,7 @@
     LaunchpadFormView,
     )
 from lp.app.errors import NotFoundError
+from lp.app.interfaces.services import IService
 from lp.app.widgets.itemswidgets import LaunchpadRadioWidgetWithDescription
 from lp.app.widgets.product import GhostCheckBoxWidget
 from lp.app.widgets.project import ProjectScopeWidget
@@ -881,6 +881,7 @@
         if self.request.is_ajax:
             validate_change = data.get('validate_change', False)
             if (validate_change and
+                information_type in PRIVATE_INFORMATION_TYPES and
                 self._bug_will_be_invisible(information_type)):
                 self.request.response.setStatus(400, "Bug Visibility")
                 return ''