launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/launchpad/revokeAccessGrants-robust-1040898 into lp:launchpad has been updated.

Description changed to:

== Implementation ==

Quick fix to raise a ValueError if ISharingService.revokeAccessGrants() is invoked without specifying at least one of bugs or branches.

This branch can land after the work to remove the sharing feature flags. If I used a flag, there would have been conflicts when both branches merged.

== Tests ==

Add new sharing service test: test_revokeAccessGrants_without_bugs_or_branches

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/services/sharingservice.py
  lib/lp/registry/services/tests/test_sharingservice.py

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/revokeAccessGrants-robust-1040898/+merge/121352
-- 
https://code.launchpad.net/~wallyworld/launchpad/revokeAccessGrants-robust-1040898/+merge/121352
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/revokeAccessGrants-robust-1040898 into lp:launchpad.