launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/test_worker_calls_update_leases into lp:maas.

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~jtv/maas/test_worker_calls_update_leases/+merge/121396

This test was failing because I had neglected to json-encode leases before sending them to the API.  Julian fixed that mistake, but it broke a test that needed the same update.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/test_worker_calls_update_leases/+merge/121396
Your team MAAS Maintainers is requested to review the proposed merge of lp:~jtv/maas/test_worker_calls_update_leases into lp:maas.

=== modified file 'src/maasserver/tests/test_api.py'
--- src/maasserver/tests/test_api.py	2012-08-27 09:06:39 +0000
+++ src/maasserver/tests/test_api.py	2012-08-27 10:40:23 +0000
@@ -2553,7 +2553,7 @@
         nodegroup_path = reverse('nodegroup_handler', args=[nodegroup.name])
         nodegroup_path = nodegroup_path.decode('ascii').lstrip('/')
         MAASClient.post.assert_called_once_with(
-            nodegroup_path, 'update_leases', leases=leases)
+            nodegroup_path, 'update_leases', leases=json.dumps(leases))
 
 
 class TestNodeGroupAPIAuth(APIv10TestMixin, TestCase):