launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Just a quick comment in looking over things. It would be best if the banner, portlet, and the actual change widget all communicated via an event vs direct calls. The widget should just fire a 'privacy_value_change' event that the banner and portlet can listen to and respond as required. In this way you're not tied to having these exact parts in place and code couple possibly be shared more from bug/code uses. Any data needed can be passed into the event as misc data.
-- 
https://code.launchpad.net/~wallyworld/launchpad/branch-infotype-portlet2-1040999/+merge/121527
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/branch-infotype-portlet2-1040999 into lp:launchpad.